zhztheplayer commented on code in PR #6228:
URL: https://github.com/apache/incubator-gluten/pull/6228#discussion_r1654827966
##########
gluten-core/src/main/java/org/apache/gluten/vectorized/JniWorkspace.java:
##########
@@ -75,14 +75,14 @@ private static JniWorkspace createDefault() {
}
}
- public static void enableDebug() {
+ public static void enableDebug(String debugDir) {
Review Comment:
`enableDebug("folder1")` should just enable debug in folder `folder1`. If
there's potential that it doesn't use `folder1`, please give user/caller a note.
I don't think it's excessive protection. Next time please close comments
like this one before merging a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
