Yohahaha commented on code in PR #6231:
URL: https://github.com/apache/incubator-gluten/pull/6231#discussion_r1663439882
##########
dev/build_arrow.sh:
##########
@@ -38,15 +36,14 @@ function install_arrow_deps {
}
function build_arrow_cpp() {
- if [ -n "$1" ]; then
- BUILD_TYPE=$1
- fi
pushd $ARROW_PREFIX/cpp
cmake_install \
-DARROW_PARQUET=ON \
-DARROW_FILESYSTEM=ON \
-DARROW_PROTOBUF_USE_SHARED=OFF \
+ -DARROW_DEPENDENCY_USE_SHARED=OFF \
+ -DARROW_DEPENDENCY_SOURCE=BUNDLED \
Review Comment:
> Considering arrow libs are generally built once then installed
it's important, hope we can reduce changes of arrow...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
