PHILO-HE commented on code in PR #6264:
URL: https://github.com/apache/incubator-gluten/pull/6264#discussion_r1664103555
##########
.github/workflows/velox_docker.yml:
##########
@@ -532,7 +532,7 @@ jobs:
fail-fast: false
matrix:
spark: [ "spark-3.2" ]
- celeborn: [ "celeborn-0.4.1", "celeborn-0.3.2-incubating" ]
+ celeborn: [ "celeborn-0.5.0", "celeborn-0.4.1",
"celeborn-0.3.2-incubating" ]
Review Comment:
Nit:
Suggest to rename it to `[ "celeborn-0.5", "celeborn-0.4", "celeborn-0.3"
]`, consistent with profile name. Maybe, need to add `celeborn-0.3` profile in
pom.
Then, `EXTRA_PROFILE="-P${{ matrix.celeborn }}"` and let pom determine which
specific version will be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
