exmy commented on code in PR #6323:
URL: https://github.com/apache/incubator-gluten/pull/6323#discussion_r1665185628
##########
cpp-ch/local-engine/Parser/SerializedPlanParser.cpp:
##########
@@ -117,15 +117,15 @@ std::string join(const ActionsDAG::NodeRawConstPtrs & v,
char c)
void logDebugMessage(const google::protobuf::Message & message, const char *
type)
{
auto * logger = &Poco::Logger::get("SerializedPlanParser");
- if (logger->debug())
+ //if (logger->debug())
{
namespace pb_util = google::protobuf::util;
pb_util::JsonOptions options;
std::string json;
auto s = pb_util::MessageToJsonString(message, &json, options);
if (!s.ok())
throw Exception(ErrorCodes::LOGICAL_ERROR, "Can not convert {} to
Json", type);
- LOG_DEBUG(logger, "{}:\n{}", type, json);
+ LOG_ERROR(logger, "{}:\n{}", type, json);
Review Comment:
keep `LOG_DEBUG`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
