yikf commented on PR #6341: URL: https://github.com/apache/incubator-gluten/pull/6341#issuecomment-2210231923
> BTW, please fix code style issue, see reference: > https://github.com/apache/incubator-gluten/blob/main/docs/developers/NewToGluten.md#javascala-code-style thanks for the reminding of codestyle. > it looks good to me. Did you observe that this config can help relieve the OOM issue on your side? yes, we have a scenario which trigger an oom is due to a large number of batches being held in a queue. making queue configurable may reduce oom occurrence, but it will also block the query thread, which is not optimal, but it is the fastest way to prevent oom. then we can implement push-based writing to refactor the logic of this piece -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
