PHILO-HE commented on code in PR #6329:
URL: https://github.com/apache/incubator-gluten/pull/6329#discussion_r1673299627
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala:
##########
@@ -837,6 +837,7 @@ class VeloxSparkPlanExecApi extends SparkPlanExecApi {
Sig[VeloxBloomFilterAggregate](ExpressionNames.BLOOM_FILTER_AGG),
Sig[TransformKeys](TRANSFORM_KEYS),
Sig[TransformValues](TRANSFORM_VALUES),
+ Sig[RaiseError](RAISE_ERROR),
Review Comment:
@gaoyangxiaozhu, I feel it may be better to move it to a common place, and
just let CH fall back for it, which may require few code change like the code
here:
https://github.com/apache/incubator-gluten/blob/1c6910e0eca3d911699686c117d68769c8216776/backends-clickhouse/src/main/scala/org/apache/gluten/utils/CHExpressionUtil.scala#L218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
