This is an automated email from the ASF dual-hosted git repository.
hongze pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 515c1cb62 [VL] Quick fix for commit conflicts (#6418)
515c1cb62 is described below
commit 515c1cb626ed55ad4fe7ee7c8734dc9651793ff0
Author: Hongze Zhang <[email protected]>
AuthorDate: Fri Jul 12 12:00:52 2024 +0900
[VL] Quick fix for commit conflicts (#6418)
---
.../org/apache/spark/sql/GlutenExpressionDataTypesValidation.scala | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/gluten-ut/test/src/test/scala/org/apache/spark/sql/GlutenExpressionDataTypesValidation.scala
b/gluten-ut/test/src/test/scala/org/apache/spark/sql/GlutenExpressionDataTypesValidation.scala
index f7dc3386a..c8b2aaba2 100644
---
a/gluten-ut/test/src/test/scala/org/apache/spark/sql/GlutenExpressionDataTypesValidation.scala
+++
b/gluten-ut/test/src/test/scala/org/apache/spark/sql/GlutenExpressionDataTypesValidation.scala
@@ -106,7 +106,7 @@ class GlutenExpressionDataTypesValidation extends
WholeStageTransformerSuite {
val castExpr = Cast(generateChildExpression(from), to)
if (castExpr.checkInputDataTypes().isSuccess) {
val glutenProject = generateGlutenProjectPlan(castExpr)
- if (glutenProject.doValidate().isValid) {
+ if (castExpr.resolved && glutenProject.doValidate().ok()) {
logInfo("## cast validation passes: cast from " + from + " to "
+ to)
} else {
logInfo("!! cast validation fails: cast from " + from + " to " +
to)
@@ -145,7 +145,7 @@ class GlutenExpressionDataTypesValidation extends
WholeStageTransformerSuite {
// Builds an expression whose child's type is really accepted in
Spark.
val targetExpr = builder(Seq(child))
val glutenProject = generateGlutenProjectPlan(targetExpr)
- if (glutenProject.doValidate().isValid) {
+ if (targetExpr.resolved && glutenProject.doValidate().ok()) {
logInfo("## validation passes: " +
targetExpr.getClass.getSimpleName + "(" + t + ")")
} else {
logInfo("!! validation fails: " +
targetExpr.getClass.getSimpleName + "(" + t + ")")
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
