Yohahaha commented on PR #6325:
URL: 
https://github.com/apache/incubator-gluten/pull/6325#issuecomment-2227347897

   > > @Yohahaha, the corresponding velox patch has been merged. Do you have 
any other comment on this gluten PR?
   > 
   > If arrow has installed in other places, seems we still set ARROW_HOME 
under velox path, could you clarify?
   > 
   > ```
   > if(${CMAKE_BUILD_TYPE} STREQUAL "Debug")
   >   set(ARROW_HOME
   >       
${VELOX_HOME}/_build/debug/CMake/resolve_dependency_modules/arrow/arrow_ep/
   >   )
   > else()
   >   set(ARROW_HOME
   >       
${VELOX_HOME}/_build/release/CMake/resolve_dependency_modules/arrow/arrow_ep
   >   )
   > endif()
   > ```
   
   mayby it's not an issue, `find_library` should find correct arrow lib if 
ARROW_HOME is wrong.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to