This is an automated email from the ASF dual-hosted git repository.
felixybw pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 8a2ac2ad8 [VL] Print exception early when raised from
ManagedReservationListener#unreserve (#6504)
8a2ac2ad8 is described below
commit 8a2ac2ad8107ec23571fe67bcf9217bd99847eb3
Author: Hongze Zhang <[email protected]>
AuthorDate: Fri Jul 19 09:51:43 2024 +0800
[VL] Print exception early when raised from
ManagedReservationListener#unreserve (#6504)
Print the error early to log to avoid further error handling/reporting
issues.
---
.../gluten/memory/listener/ManagedReservationListener.java | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git
a/gluten-data/src/main/java/org/apache/gluten/memory/listener/ManagedReservationListener.java
b/gluten-data/src/main/java/org/apache/gluten/memory/listener/ManagedReservationListener.java
index b7d6ecd67..4af8eb4e3 100644
---
a/gluten-data/src/main/java/org/apache/gluten/memory/listener/ManagedReservationListener.java
+++
b/gluten-data/src/main/java/org/apache/gluten/memory/listener/ManagedReservationListener.java
@@ -53,10 +53,15 @@ public class ManagedReservationListener implements
ReservationListener {
@Override
public long unreserve(long size) {
synchronized (this) {
- long freed = target.repay(size);
- sharedUsage.inc(-freed);
- Preconditions.checkState(freed == size);
- return freed;
+ try {
+ long freed = target.repay(size);
+ sharedUsage.inc(-freed);
+ Preconditions.checkState(freed == size);
+ return freed;
+ } catch (Exception e) {
+ LOG.error("Error unreserving memory from target", e);
+ throw e;
+ }
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
