kecookier commented on PR #6503: URL: https://github.com/apache/incubator-gluten/pull/6503#issuecomment-2238794945
> @kecookier Could you remove the `setFileReadProperties` method in `LocalFilesNode` if it is unused. @liujiayi771 Thanks! At first, I missed `IcebergLocalFilesNode` in my situation. I mistakenly thought all constructors of LocalFilesNode required properties; actually, IcebergLocalFilesNode did not need them. Now, keeping `setFileReadProperties` is a better choice. I will update the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
