liujiayi771 commented on code in PR #6508:
URL: https://github.com/apache/incubator-gluten/pull/6508#discussion_r1684319295
##########
gluten-iceberg/src/test/scala/org/apache/gluten/execution/VeloxIcebergSuite.scala:
##########
@@ -457,4 +457,62 @@ class VeloxIcebergSuite extends WholeStageTransformerSuite
{
}
}
}
+
+ // Spark configuration spark.sql.iceberg.handle-timestamp-without-timezone
is not supported
+ // in Spark 3.4
+ testWithSpecifiedSparkVersion("iceberg partition type - timestamp",
Array("3.2", "3.3", "3.5")) {
Review Comment:
You can combine these two test cases.
```scala
Seq("true", "false").foreach {
flag =>
withSQLConf(
"spark.sql.iceberg.handle-timestamp-without-timezone" -> flag,
"spark.sql.iceberg.use-timestamp-without-timezone-in-new-tables" ->
flag) {
....
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
