liuneng1994 commented on code in PR #6558:
URL: https://github.com/apache/incubator-gluten/pull/6558#discussion_r1687806566
##########
backends-clickhouse/src/main/java/org/apache/gluten/vectorized/BatchIterator.java:
##########
@@ -77,8 +80,17 @@ public IMetrics getMetricsInternal() {
return new NativeMetrics(nativeFetchMetrics(handle));
}
+ public void updatePeakMemory() {
+ if (TaskContext.get() != null) {
+
TaskContext.get().taskMetrics().setPeakExecutionMemory(nativeCurrentPeakMemory());
+ }
+ }
+
@Override
public void closeInternal() {
+ // CH backend uses Clickhouse to manage off heap and updates memory
statistics at the end of the
Review Comment:
没什么影响，之前spark的管理方式也是在task结束的时候更新，ui也只能在结束后查看到,唯一的区别是 spark的 offheap
execution memory, storage memory在统计上会是零，不过对native来说也不会区分这两种类型的内存。这个两个值没啥作用
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
