FelixYBW commented on code in PR #6554:
URL: https://github.com/apache/incubator-gluten/pull/6554#discussion_r1689028575
##########
cpp/core/jni/JniCommon.h:
##########
@@ -403,26 +403,34 @@ class SparkAllocationListener final : public
gluten::AllocationListener {
env->CallLongMethod(jListenerGlobalRef_, jReserveMethod_, size);
checkException(env);
}
- // atomic operation is enough here, no need to use mutex
- bytesReserved_.fetch_add(size);
- maxBytesReserved_.store(std::max(bytesReserved_.load(),
maxBytesReserved_.load()));
+ usedBytes_ += size;
+ while (true) {
+ int64_t savedPeakBytes = peakBytes_;
+ if (usedBytes_ <= savedPeakBytes) {
+ break;
+ }
+ // usedBytes_ > savedPeakBytes, update peak
+ if (peakBytes_.compare_exchange_weak(savedPeakBytes, usedBytes_)) {
+ break;
+ }
+ }
Review Comment:
With C++26 in future, we can use fetch_max directly.
https://en.cppreference.com/w/cpp/atomic/atomic/fetch_max
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
