xumingming commented on code in PR #6563:
URL: https://github.com/apache/incubator-gluten/pull/6563#discussion_r1689060975
##########
cpp/velox/tests/MemoryManagerTest.cc:
##########
@@ -50,7 +49,7 @@ class MemoryManagerTest : public ::testing::Test {
std::unordered_map<std::string, std::string> conf = {
{kMemoryReservationBlockSize,
std::to_string(kMemoryReservationBlockSizeDefault)},
{kVeloxMemInitCapacity, std::to_string(kVeloxMemInitCapacityDefault)}};
- initVeloxBackend(conf);
+ gluten::VeloxBackend::create(conf);
Review Comment:
on macOS, even if we added link to `velox` target, the symbol
`gluten::VeloxBackend::create` is missing in libvelox.dylib, not sure why it
works on linux, and NOT works on macOS.
```
Undefined symbols for architecture arm64:
"gluten::VeloxBackend::create(std::__1::unordered_map<std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char>>,
std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char>>, std::__1::hash<std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char>>>,
std::__1::equal_to<std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char>>>,
std::__1::allocator<std::__1::pair<std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char>> const,
std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char>>>>> const&)", referenced from:
gluten::initVeloxBackend(std::__1::unordered_map<std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char>>,
std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char>>, std::__1::hash<std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char>>>,
std::__1::equal_to<std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char>>>,
std::__1::allocator<std::__1::pair<std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char>> const,
std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char>>>>>&) in
libvelox_benchmark_common.a[3](BenchmarkUtils.cc.o)
"gluten::VeloxMemoryManager::shrink(long long)", referenced from:
gluten::MemoryManagerTest_memoryPoolWithBlockReseravtion_Test::TestBody() in
MemoryManagerTest.cc.o
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
