This is an automated email from the ASF dual-hosted git repository.
philo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 8ab0b1020 [GLUTEN-6562][VL] Decouple BUILD_BENCHMARKS and BUILD_TESTS
build options (#6563)
8ab0b1020 is described below
commit 8ab0b10205d924d3accd25dc23ced9d9a3d99812
Author: Jaime Pan <[email protected]>
AuthorDate: Wed Jul 24 17:31:51 2024 +0800
[GLUTEN-6562][VL] Decouple BUILD_BENCHMARKS and BUILD_TESTS build options
(#6563)
---
cpp/velox/tests/CMakeLists.txt | 4 ++--
cpp/velox/tests/MemoryManagerTest.cc | 3 +--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/cpp/velox/tests/CMakeLists.txt b/cpp/velox/tests/CMakeLists.txt
index f3d65f127..dac83cd87 100644
--- a/cpp/velox/tests/CMakeLists.txt
+++ b/cpp/velox/tests/CMakeLists.txt
@@ -29,8 +29,8 @@ function(add_velox_test TEST_EXEC)
target_include_directories(
${TEST_EXEC} PRIVATE ${CMAKE_SOURCE_DIR}/velox ${CMAKE_SOURCE_DIR}/src
${VELOX_BUILD_PATH}/_deps/duckdb-src/src/include)
- target_link_libraries(${TEST_EXEC} velox_benchmark_common GTest::gtest
- GTest::gtest_main)
+ target_link_libraries(${TEST_EXEC} velox GTest::gtest GTest::gtest_main
+ google::glog)
gtest_discover_tests(${TEST_EXEC} DISCOVERY_MODE PRE_TEST)
endfunction()
diff --git a/cpp/velox/tests/MemoryManagerTest.cc
b/cpp/velox/tests/MemoryManagerTest.cc
index 52f2fa8b6..d86bd46e2 100644
--- a/cpp/velox/tests/MemoryManagerTest.cc
+++ b/cpp/velox/tests/MemoryManagerTest.cc
@@ -15,7 +15,6 @@
* limitations under the License.
*/
-#include "benchmarks/common/BenchmarkUtils.h"
#include "compute/VeloxBackend.h"
#include "config/VeloxConfig.h"
#include "memory/VeloxMemoryManager.h"
@@ -50,7 +49,7 @@ class MemoryManagerTest : public ::testing::Test {
std::unordered_map<std::string, std::string> conf = {
{kMemoryReservationBlockSize,
std::to_string(kMemoryReservationBlockSizeDefault)},
{kVeloxMemInitCapacity, std::to_string(kVeloxMemInitCapacityDefault)}};
- initVeloxBackend(conf);
+ gluten::VeloxBackend::create(conf);
}
void SetUp() override {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
