jinchengchenghh commented on PR #6575: URL: https://github.com/apache/incubator-gluten/pull/6575#issuecomment-2249227114
Yes, We could compile the expression for all the scalar functions. https://github.com/facebookincubator/velox/blob/main/velox/expression/ExprCompiler.cpp#L423 But it will take some expense, and our final destination is to support all the functions, so now we just list the functions unsupported type in validateScalarFunctions https://github.com/apache/incubator-gluten/blob/main/cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc#L195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
