wForget commented on code in PR #6569:
URL: https://github.com/apache/incubator-gluten/pull/6569#discussion_r1692568747
##########
dev/package-vcpkg.sh:
##########
@@ -13,5 +16,13 @@ if [ "$LINUX_OS" == "centos" ]; then
source /opt/rh/devtoolset-9/enable
fi
fi
+
+# prepare vcpkg environments
source ./dev/vcpkg/env.sh
-./dev/buildbundle-veloxbe.sh --build_tests=ON --build_benchmarks=ON
--enable_s3=ON --enable_hdfs=ON
+
+# build gluten with velox backend, prompt always respond y
+export PROMPT_ALWAYS_RESPOND=y
+./dev/buildbundle-veloxbe.sh --build_tests=ON --build_benchmarks=ON
--enable_s3=ON --enable_hdfs=ON "$@"
+
+# make thirdparty package
+./dev/build-thirdparty.sh
Review Comment:
> Extract build-thirdparty.sh script
> Set PROMPT_ALWAYS_RESPOND=y for package scripts
> Pass package arguments to buildbundle-veloxbe.sh
Are these improvements reasonable? If so, I will continue working
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
