FelixYBW commented on code in PR #5952:
URL: https://github.com/apache/incubator-gluten/pull/5952#discussion_r1694028806
##########
cpp/core/operators/c2r/ColumnarToRow.h:
##########
@@ -27,7 +28,15 @@ class ColumnarToRowConverter {
virtual ~ColumnarToRowConverter() = default;
- virtual void convert(std::shared_ptr<ColumnarBatch> cb = nullptr) = 0;
+ // We will start conversion from the 'rowId' row of 'cb'. The maximum memory
consumption during the grabbing and
+ // swapping process is 'memoryThreshold' bytes. The number of rows
successfully converted is stored in the 'numRows_'
+ // variable.
+ virtual void
+ convert(std::shared_ptr<ColumnarBatch> cb = nullptr, int64_t rowId = 0,
int64_t memoryThreshold = INT64_MAX) = 0;
Review Comment:
@zhztheplayer can you fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
