Re: [PR] [GLUTEN-6590][CH] Support compact mergetree file on s3 [incubator-gluten]

Mon, 29 Jul 2024 01:29:24 -0700 


lwz9103 commented on code in PR #6591:
URL: https://github.com/apache/incubator-gluten/pull/6591#discussion_r1694814282


##########
cpp-ch/local-engine/Common/CHUtil.cpp:
##########
@@ -556,7 +556,7 @@ std::vector<String> 
BackendInitializerUtil::wrapDiskPathConfig(
     if (path_prefix.empty() && path_suffix.empty())
         return changed_paths;
     Poco::Util::AbstractConfiguration::Keys disks;
-    std::unordered_set<String> disk_types = {"s3", "hdfs_gluten", "cache"};
+    std::unordered_set<String> disk_types = {"s3_gluten", "hdfs_gluten", 
"cache"};

Review Comment:
   Disk type is already set to s3_gluten.
   
![image](https://github.com/user-attachments/assets/490c85df-ed90-4cbf-9d1e-ca33a29ad0bf)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to