WangGuangxin commented on code in PR #5954:
URL: https://github.com/apache/incubator-gluten/pull/5954#discussion_r1695399987
##########
backends-velox/src/test/scala/org/apache/gluten/execution/VeloxScanSuite.scala:
##########
@@ -74,4 +77,34 @@ class VeloxScanSuite extends VeloxWholeStageTransformerSuite
{
}
}
}
+
+ test("unsupported data type scan filter pushdown") {
+ withTempView("t") {
+ withTempDir {
+ dir =>
+ val path = dir.getAbsolutePath
+ val schema = StructType(
+ Array(
+ StructField("short_decimal_field", DecimalType(5, 2), true),
+ StructField("long_decimal_field", DecimalType(32, 8), true),
+ StructField("binary_field", BinaryType, true),
+ StructField("timestamp_field", TimestampType, true)
+ ))
+ RandomParquetDataGenerator(0).generateRandomData(spark, schema, 10,
Some(path))
+ spark.catalog.createTable("t", path, "parquet")
+ runQueryAndCompare(
+ """select * from t where long_decimal_field = 3.14""".stripMargin
+ )(checkGlutenOperatorMatch[FileSourceScanExecTransformer])
+ runQueryAndCompare(
+ """select * from t where short_decimal_field = 3.14""".stripMargin
+ )(checkGlutenOperatorMatch[FileSourceScanExecTransformer])
+ runQueryAndCompare(
+ """select * from t where binary_field = '3.14'""".stripMargin
+ )(checkGlutenOperatorMatch[FileSourceScanExecTransformer])
+ runQueryAndCompare(
+ """select * from t where timestamp_field =
current_timestamp()""".stripMargin
Review Comment:
Yes, I think it's already supported in velox side. But as for now, Gluten
can still fallback since `mapToFilters` doesn't support yet. I think we can
support it in next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
