This is an automated email from the ASF dual-hosted git repository.
lgbo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 73fd854e2 fix a bug in serializing aggregating keys which are
complicated types (#6624)
73fd854e2 is described below
commit 73fd854e25e84c0c6258e82517f657705516fc88
Author: lgbo <[email protected]>
AuthorDate: Tue Jul 30 10:03:07 2024 +0800
fix a bug in serializing aggregating keys which are complicated types
(#6624)
---
.../execution/GlutenClickHouseTPCHSaltNullParquetSuite.scala | 12 ++++++++++++
cpp-ch/clickhouse.version | 2 +-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git
a/backends-clickhouse/src/test/scala/org/apache/gluten/execution/GlutenClickHouseTPCHSaltNullParquetSuite.scala
b/backends-clickhouse/src/test/scala/org/apache/gluten/execution/GlutenClickHouseTPCHSaltNullParquetSuite.scala
index 6d5c9c463..694a9f253 100644
---
a/backends-clickhouse/src/test/scala/org/apache/gluten/execution/GlutenClickHouseTPCHSaltNullParquetSuite.scala
+++
b/backends-clickhouse/src/test/scala/org/apache/gluten/execution/GlutenClickHouseTPCHSaltNullParquetSuite.scala
@@ -2781,5 +2781,17 @@ class GlutenClickHouseTPCHSaltNullParquetSuite extends
GlutenClickHouseTPCHAbstr
compareResultsAgainstVanillaSpark(sql, true, { _ => })
}
}
+
+ test("GLUTEN-6583 serializing bug in aggregating with nullable compilated
type keys") {
+ val sql = """
+ |select n_regionkey, x, count(1) from (
+ | select n_regionkey, if(n_regionkey = 'xx', null, x) as x
from (
+ | select n_regionkey, array(n_name, if(n_name != 'KENYA',
n_name, null)) as x
+ | from nation
+ | )
+ |) group by n_regionkey, x;
+ |""".stripMargin
+ compareResultsAgainstVanillaSpark(sql, true, { _ => })
+ }
}
// scalastyle:on line.size.limit
diff --git a/cpp-ch/clickhouse.version b/cpp-ch/clickhouse.version
index a67f0227c..9284537ad 100644
--- a/cpp-ch/clickhouse.version
+++ b/cpp-ch/clickhouse.version
@@ -1,4 +1,4 @@
CH_ORG=Kyligence
CH_BRANCH=rebase_ch/20240727
-CH_COMMIT=7d0829e25b9
+CH_COMMIT=d09605082e3
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
