rui-mo commented on PR #6618: URL: https://github.com/apache/incubator-gluten/pull/6618#issuecomment-2259737014
> One question about the lgoic here. I thought there is already logic to split filters to subfield filters and remaining filters in Velox: https://github.com/facebookincubator/velox/blob/main/velox/connectors/hive/HiveConnectorUtil.cpp#L790 I wonder what's the reason we maintain similar logic here or what's the difference between them. Thanks. @zhli1142015 Thanks for bringing this up. We were using our implementation from the start since Velox added the function `extractFiltersFromRemainingFilter` after we implemented it in Gluten. One distinction I see is that Gluten eliminates the filters to be pushed down from the call expression, whereas Velox does not. Before taking use of the Velox implementation, we might need to verify Gluten supported cases and fix the met issue if there is. We can then seamlessly transition to the Velox implementation. @FelixYBW Do you have any suggestion? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
