SteNicholas commented on code in PR #6657:
URL: https://github.com/apache/incubator-gluten/pull/6657#discussion_r1698444933
##########
gluten-celeborn/clickhouse/src/main/scala/org/apache/spark/shuffle/CHCelebornColumnarShuffleWriter.scala:
##########
@@ -71,7 +71,12 @@ class CHCelebornColumnarShuffleWriter[K, V](
}
}
- assert(nativeShuffleWriter != -1L)
+ // If all of the ColumnarBatch have empty rows, the nativeShuffleWriter
still equals -1
Review Comment:
When `!records.hasNext=true`, does this also need to invoke
`handleEmptyIterator`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
