WangGuangxin commented on code in PR #6652:
URL: https://github.com/apache/incubator-gluten/pull/6652#discussion_r1699332856


##########
shims/spark34/src/main/scala/org/apache/spark/sql/execution/FileSourceScanExecShim.scala:
##########
@@ -98,7 +105,9 @@ abstract class FileSourceScanExecShim(
 
   @transient override lazy val dynamicallySelectedPartitions: 
Array[PartitionDirectory] = {
     val dynamicPartitionFilters =
-      partitionFilters.filter(isDynamicPruningFilter)
+      partitionFilters
+        .filter(isDynamicPruningFilter)
+        .filterNot(isBloomFilterMightContain)

Review Comment:
   > completely
   
   @zhztheplayer Only disable the case when bloomfilter is applied on hive 
table's partition column ( join key is hive table's partition column). 
   
   In most case, bloom filter is applied on data column, which is not affected 
by this PR.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to