Yohahaha commented on PR #6670: URL: https://github.com/apache/incubator-gluten/pull/6670#issuecomment-2262355500
> > > > would you consider implement such logic into a Velox operator like ValueStream? > > > > > > > > > It will be the next step of the topic. See [a related comment](https://github.com/apache/incubator-gluten/pull/5952#issuecomment-2254795661) from another PR. > > > The major pros of doing it in Velox is to avoid breaking one Velox task into several. > > > > And lots java/scala changes can be removed. > > > > > > > > > Regarding the code, it's expected most of C++ code can be removed then. However it might still needed to have a JVM side plan node to map to Velox's corresponding plan node. > > > > > > yeah, indeed, I have done a POC for above ideas, just one rule/transformer/velox operator added. > > That sounds great. Do you tend to contribute to upstream Velox? If so please feel free to open a PR to refresh the feature in Gluten once Velox change has landed. yes, I'm preparing the codes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
