zhztheplayer commented on PR #6693: URL: https://github.com/apache/incubator-gluten/pull/6693#issuecomment-2266594781
> As I documented, since the slice has little overhead, let's just honor the max batch size as 1x. If I remember correctly in our code there were some places producing columnar batches that use default batch size `4096` as a minimal threshold. Which means we have chance to frequently get batches with size say, 4100 or something. Let's at least relax a little bit to allow that kind of batches to pass? Otherwise very small batches could be produced. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
