This is an automated email from the ASF dual-hosted git repository.
marong pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 01a44d902 [VL] Remove redundant hash function in substrait function
validation (#6690)
01a44d902 is described below
commit 01a44d9023dc9954739adab52e2ce0c54e38d00b
Author: Jin Chengcheng <[email protected]>
AuthorDate: Mon Aug 5 09:02:13 2024 +0800
[VL] Remove redundant hash function in substrait function validation (#6690)
---
cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc
b/cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc
index c18d26598..7bb0eab77 100644
--- a/cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc
+++ b/cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc
@@ -68,7 +68,8 @@ static const std::unordered_set<std::string> kBlackList = {
"trunc",
"sequence",
"approx_percentile",
- "get_array_struct_fields"};
+ "get_array_struct_fields",
+ "map_from_arrays"};
} // namespace
@@ -189,9 +190,6 @@ bool SubstraitToVeloxPlanValidator::validateScalarFunction(
return validateRound(scalarFunction, inputType);
} else if (name == "extract") {
return validateExtractExpr(params);
- } else if (name == "map_from_arrays") {
- LOG_VALIDATION_MSG("map_from_arrays is not supported.");
- return false;
} else if (name == "concat") {
for (const auto& type : types) {
if (type.find("struct") != std::string::npos || type.find("map") !=
std::string::npos ||
@@ -200,14 +198,6 @@ bool SubstraitToVeloxPlanValidator::validateScalarFunction(
return false;
}
}
- } else if (name == "murmur3hash") {
- for (const auto& type : types) {
- if (type.find("struct") != std::string::npos || type.find("map") !=
std::string::npos ||
- type.find("list") != std::string::npos) {
- LOG_VALIDATION_MSG(type + " is not supported in murmur3hash.");
- return false;
- }
- }
}
// Validate regex functions.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
