ulysses-you commented on PR #6706: URL: https://github.com/apache/incubator-gluten/pull/6706#issuecomment-2268527458
thank you @baibaichen , can we make a copy for CH backend ? I think it's unnecessary to have to make abstract for diffferent backends... it just makes things complex. I'd like a stable code base. For `ColumnarWriteFiles`, we can add `VeloxColumnarWriteFiles` and `CHColumnarWriteFiles`, then you can do anything in `CHColumnarWriteFiles` and I also can help review that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
