zml1206 commented on issue #6688: URL: https://github.com/apache/incubator-gluten/issues/6688#issuecomment-2269453628
> @zml1206, I remember Gluten replaces ObjectHashAggregate with its HashAggregate, not SortAggregate. Right? Yea, but `CollectRewriteRule` rewrite collect to velox_collect, velox_collect is not `TypedImperativeAggregate`. It affects the aggregate type selection when converting spark logical plan to physical plan, only `TypedImperativeAggregate` can create `ObjectHashAggregateExec`. For example, `select collect_set(string_field), velox_unsupport_udaf() from t`, in vanilla spark is `ObjectHashAggregateExec`, in gluten is `SortAggregateExec`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
