zhztheplayer commented on code in PR #6692: URL: https://github.com/apache/incubator-gluten/pull/6692#discussion_r1704869182
########## docs/get-started/Velox.md: ########## @@ -279,7 +279,7 @@ mvn clean package -Pbackends-velox -Pspark-3.3 -Puniffle -DskipTests Then add the Uniffle and Spark Celeborn Client packages to your Spark application's classpath(usually add them into `$SPARK_HOME/jars`). - Uniffle: rss-client-spark3-shaded-[uniffleVersion].jar -- Gluten: gluten-uniffle-velox-xxx-SNAPSHOT-3.x.jar +- Gluten: gluten-velox-bundle-spark3.x_2.12-xx_xx_xx-SNAPSHOT.jar (When `-Puniffle` is specified the gluten bundle jar includes `gluten-uniffle-package`.) Review Comment: > When `-Puniffle` is specified the gluten bundle jar includes `gluten-uniffle-package`. Would you reword to something like > The bundled Gluten Jar. Make sure `-Puniffle` is specified when it is built. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
