yma11 commented on code in PR #6712:
URL: https://github.com/apache/incubator-gluten/pull/6712#discussion_r1706246924
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala:
##########
@@ -158,11 +159,12 @@ object VeloxBackendSettings extends BackendSettingsApi {
CharVarcharUtils.getRawTypeString(metadata) + " not support"
case StructField(_, TimestampType, _, _) => "TimestampType not
support"
}
- if (!GlutenConfig.getConf.forceComplexTypeScanFallbackEnabled) {
- validateTypes(typeValidator)
- } else {
- validateTypes(orcTypeValidatorWithComplexTypeFallback)
- }
+ ValidationResult.succeeded
Review Comment:
This is for just a try how the change affect ORC related UTs. It turns out
timestamp support has result mismatch issue. We may still keep this option for
ORC as it's not fully verified as Parquet. For parquet, we have problems in
nested struct type support in Gluten and I am looking into that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
