zml1206 commented on PR #6744: URL: https://github.com/apache/incubator-gluten/pull/6744#issuecomment-2272996731
> Thanks for working on this. > > Since the new rule looks like a manually written "coster", actually I recommend to use RAS planner to achieve the same. > > RAS planner is so far mature enough to handle cases like this. All we need is to change the cost model. > > I know it's a safer choice to make the change in legacy planner but I am afraid using single rules to do such fallback is a way that increases planner code's complexity silently until being unmaintainable. What are the current shortcomings of RAS? When is it expected to be enabled by default? @zhztheplayer At present, simple query scenarios can easily hit this case, causing performance regression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
