yma11 commented on code in PR #6738: URL: https://github.com/apache/incubator-gluten/pull/6738#discussion_r1707135662
########## docs/get-started/Velox.md: ########## @@ -314,8 +314,7 @@ First of all, compile gluten-delta module by a `delta` profile, as follows: mvn clean package -Pbackends-velox -Pspark-3.3 -Pdelta -DskipTests ``` -Then, put the additional `gluten-delta-XX-SNAPSHOT.jar` to the class path (usually it's `$SPARK_HOME/jars`). -The gluten-delta jar is in `gluten-delta/target` directory. +Once built successfully, delta features will be included in gluten-velox-bundle-X jar. Review Comment: Put line `318` together with this line please. Can you also help update the content for iceberg in this doc? seems there is some duplicated contents. ``` Once built successfully, iceberg features will be included in gluten-velox-bundle-X jar. Then you can query iceberg table by gluten/velox without scan's fallback. After the two steps, you can query iceberg table by gluten/velox without scan's fallback. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
