rui-mo commented on code in PR #6707:
URL: https://github.com/apache/incubator-gluten/pull/6707#discussion_r1711022999
##########
gluten-ut/spark32/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenMathExpressionsSuite.scala:
##########
@@ -121,6 +121,9 @@ class GlutenMathExpressionsSuite extends
MathExpressionsSuite with GlutenTestsTr
checkEvaluation(Round(-3.5, 0), -4.0)
checkEvaluation(Round(-0.35, 1), -0.4)
checkEvaluation(Round(-35, -1), -40)
+ checkEvaluation(Round(1.12345678901234567, 8), 1.12345679)
+ checkEvaluation(Round(-0.98765432109876543, 5), -0.98765)
+ checkEvaluation(Round(12345.67890123456789, 6), 12345.678901)
Review Comment:
Thanks for clarifying. I see your point.
> I think we seem to be using double as an alternative to java bigdecimal
at multiple places.
Just curious. Have you noticed other issues except for the round-related
ones?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
