This is an automated email from the ASF dual-hosted git repository.
liuneng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 9717568c8 [GLUTEN-6768][CH] Clear mixed join contition to avoid
uneccessary data copy #6769
9717568c8 is described below
commit 9717568c8d3ccc3a4b19798f5e429e30bde00a36
Author: lgbo <[email protected]>
AuthorDate: Fri Aug 9 20:56:27 2024 +0800
[GLUTEN-6768][CH] Clear mixed join contition to avoid uneccessary data copy
#6769
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Fixes: #6768
The mixed join condition doesn't clear the unused input columns, this will
cause uneccessary data copy during joining.
It's one of the issues which are noticed in #6768
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration
tests, manual tests)
unit tests
(If this patch involves UI changes, please attach a screenshot; otherwise,
remove this)
---
cpp-ch/local-engine/Parser/JoinRelParser.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/cpp-ch/local-engine/Parser/JoinRelParser.cpp
b/cpp-ch/local-engine/Parser/JoinRelParser.cpp
index 8fbaf2fec..b217a9bd9 100644
--- a/cpp-ch/local-engine/Parser/JoinRelParser.cpp
+++ b/cpp-ch/local-engine/Parser/JoinRelParser.cpp
@@ -593,6 +593,7 @@ bool JoinRelParser::applyJoinFilter(
if (!allow_mixed_condition)
return false;
auto mixed_join_expressions_actions = expressionsToActionsDAG({expr},
mixed_header);
+ mixed_join_expressions_actions.removeUnusedActions();
table_join.getMixedJoinExpression()
=
std::make_shared<DB::ExpressionActions>(std::move(mixed_join_expressions_actions),
ExpressionActionsSettings::fromContext(context));
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
