ArnavBalyan commented on issue #6368: URL: https://github.com/apache/incubator-gluten/issues/6368#issuecomment-2282193598
Hi I can add support for this. I see two ways to do this: 1. Handle all logs centrally via glog. Glog supports custom sinks where users can redirect logs to addition sinks. But this logic needs to be hacked to disable the default glog behaviour, introduce a custom sink, and redact information there. Currently there is no simple way to do it since glog does not support it. (I have raised a request in glog) 2. Until #1 can be supported, a custom macro can be introduced for sensitive logs. Something like `SENSITIVE_LOG(INFO)`. Which can be called by callers. This would be hard to enforce since LOG(severity) is used commonly. I feel #2 may be simpler until glog provides an easy way to do this. Would love to get your thoughts cc @FelixYBW @PHILO-HE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
