This is an automated email from the ASF dual-hosted git repository.
liuneng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new e3cf45783 [GLUTEN-6778][CH] Enable percent_rank again #6779
e3cf45783 is described below
commit e3cf457833626da075a1ac1788fdefd4302e946b
Author: lgbo <[email protected]>
AuthorDate: Mon Aug 12 11:13:38 2024 +0800
[GLUTEN-6778][CH] Enable percent_rank again #6779
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Fixes: #6778
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration
tests, manual tests)
unit tests
(If this patch involves UI changes, please attach a screenshot; otherwise,
remove this)
---
.../scala/org/apache/gluten/backendsapi/clickhouse/CHBackend.scala | 3 ++-
.../execution/tpch/GlutenClickHouseTPCHSaltNullParquetSuite.scala | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git
a/backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHBackend.scala
b/backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHBackend.scala
index a115ca712..e53f03300 100644
---
a/backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHBackend.scala
+++
b/backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHBackend.scala
@@ -308,7 +308,8 @@ object CHBackendSettings extends BackendSettingsApi with
Logging {
}
wExpression.windowFunction match {
- case _: RowNumber | _: AggregateExpression | _: Rank | _:
DenseRank | _: NTile =>
+ case _: RowNumber | _: AggregateExpression | _: Rank | _:
DenseRank | _: PercentRank |
+ _: NTile =>
allSupported = allSupported
case l: Lag =>
checkLagOrLead(l.third)
diff --git
a/backends-clickhouse/src/test/scala/org/apache/gluten/execution/tpch/GlutenClickHouseTPCHSaltNullParquetSuite.scala
b/backends-clickhouse/src/test/scala/org/apache/gluten/execution/tpch/GlutenClickHouseTPCHSaltNullParquetSuite.scala
index 912a5c95d..0efc1414c 100644
---
a/backends-clickhouse/src/test/scala/org/apache/gluten/execution/tpch/GlutenClickHouseTPCHSaltNullParquetSuite.scala
+++
b/backends-clickhouse/src/test/scala/org/apache/gluten/execution/tpch/GlutenClickHouseTPCHSaltNullParquetSuite.scala
@@ -978,7 +978,7 @@ class GlutenClickHouseTPCHSaltNullParquetSuite extends
GlutenClickHouseTPCHAbstr
compareResultsAgainstVanillaSpark(sql, true, { _ => })
}
- ignore("window percent_rank") {
+ test("window percent_rank") {
val sql =
"""
|select n_regionkey, n_nationkey,
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
