zhztheplayer commented on PR #6835: URL: https://github.com/apache/incubator-gluten/pull/6835#issuecomment-2290376947
I suspect how it actually helps if we make such changes. For example both Spark and Velox doesn't have a join type `Right Anti` at the moment (despite that whether they will add it in future or not). So it may look confusing to have it defined in the interchange protocol. As commented in https://github.com/apache/incubator-gluten/pull/6833#issuecomment-2290309584, physical plans would vary more than logical plans in a project like Gluten. We are already following both Spark's and Velox/CH's plan protocols. It could have chance to start messing things up if we strictly follow another one in the middle layer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
