zhztheplayer commented on code in PR #6854:
URL: https://github.com/apache/incubator-gluten/pull/6854#discussion_r1717912733
##########
gluten-core/src/main/scala/org/apache/gluten/execution/JoinExecTransformer.scala:
##########
@@ -167,7 +167,8 @@ trait HashJoinLikeExecTransformer extends BaseJoinExec with
TransformSupport {
}
}
- protected lazy val substraitJoinType: JoinRel.JoinType =
SubstraitUtil.toSubstrait(joinType)
+ protected lazy val substraitJoinType: JoinRel.JoinType =
+ SubstraitUtil.toSubstrait(joinType, needSwitchChildren)
Review Comment:
Does the change benefit Velox backend? If not, is it possible to make the
variable abstract? Then we can move the change to CH backend.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
