boneanxs commented on code in PR #5874:
URL: https://github.com/apache/incubator-gluten/pull/5874#discussion_r1718199975
##########
gluten-data/src/main/java/org/apache/gluten/vectorized/ColumnarBatchOutIterator.java:
##########
@@ -80,7 +80,11 @@ public IMetrics getMetricsInternal() throws IOException,
ClassNotFoundException
}
public long spill(long size) {
- return nativeSpill(iterHandle, size);
+ if (!closed.get()) {
Review Comment:
Recently I also meet this issue(we haven't include this pr yet). But I'm
curious in this way, IIUC, we can't spill memory that this
`NativeMemoryManager` holding if the iterator is closed? Though we still hold
the memory after the iterator is closed.
If it's an issue, can we directly get `NativeMemoryManager` to spill itself?
By calling `shrinkCapacity({pool}, remaining)` in the native.
@zhztheplayer @WangGuangxin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
