ArnavBalyan commented on code in PR #6793:
URL: https://github.com/apache/incubator-gluten/pull/6793#discussion_r1718260998
##########
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala:
##########
@@ -673,7 +674,8 @@ object GlutenConfig {
// gcs config
SPARK_GCS_STORAGE_ROOT_URL,
SPARK_GCS_AUTH_TYPE,
- SPARK_GCS_AUTH_SERVICE_ACCOUNT_JSON_KEYFILE
+ SPARK_GCS_AUTH_SERVICE_ACCOUNT_JSON_KEYFILE,
+ GLUTEN_REGEX_LOG_REDACTION
Review Comment:
There are alot of incompatibilities, it's just one of the things where c++
and java don't have complete parity, I would rather, we provide limited support
for the same config, or allow users to provide regex supported by c++ using a
different properties. Option 1 is better for now and later we can add support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
