jinchengchenghh commented on code in PR #6872:
URL: https://github.com/apache/incubator-gluten/pull/6872#discussion_r1719256302
##########
cpp/velox/shuffle/VeloxShuffleReader.cc:
##########
@@ -450,7 +451,7 @@ std::shared_ptr<ColumnarBatch>
VeloxSortShuffleReaderDeserializer::deserializeTo
return std::make_shared<VeloxColumnarBatch>(std::move(rowVector));
}
-class VeloxRssSortShuffleReaderDeserializer::VeloxInputStream : public
facebook::velox::ByteInputStream {
+class VeloxRssSortShuffleReaderDeserializer::VeloxInputStream : public
facebook::velox::GlutenByteInputStream {
Review Comment:
I make a workaround here because some API is removed by
https://github.com/facebookincubator/velox/pull/10717 and
https://github.com/facebookincubator/velox/pull/10761/files
Can you help to refactor it when you are free? @marin-ma Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
