liuneng1994 commented on code in PR #6841:
URL: https://github.com/apache/incubator-gluten/pull/6841#discussion_r1722599954
##########
cpp-ch/local-engine/Storages/SubstraitSource/ReadBufferBuilder.cpp:
##########
@@ -205,25 +202,31 @@ class LocalFileReadBufferBuilder : public
ReadBufferBuilder
#if USE_HDFS
class HDFSFileReadBufferBuilder : public ReadBufferBuilder
{
+ using ReadBufferCreator =
std::function<std::unique_ptr<DB::ReadBufferFromFileBase>(bool restricted_seek,
const DB::StoredObject & object)>;
public:
explicit HDFSFileReadBufferBuilder(DB::ContextPtr context_) :
ReadBufferBuilder(context_), context(context_) { }
~HDFSFileReadBufferBuilder() override = default;
std::unique_ptr<DB::ReadBuffer>
build(const substrait::ReadRel::LocalFiles::FileOrFiles & file_info, bool
set_read_util_position) override
{
- auto config = HdfsConfig::loadFromContext(context);
+ DB::ReadSettings read_settings = getReadSettings(context);
+ auto & config = context->getConfigRef();
+ auto hdfs_config = HdfsConfig::loadFromContext(config, read_settings);
Poco::URI file_uri(file_info.uri_file());
std::string uri_path = "hdfs://" + file_uri.getHost();
if (file_uri.getPort())
- uri_path += ":" + std::to_string(file_uri.getPort());
+ uri_path += ":" +
std::to_string(static_cast<unsigned>(file_uri.getPort()));
- DB::ReadSettings read_settings;
- std::unique_ptr<DB::ReadBuffer> read_buffer;
+ std::cout <<
"read_from_filesystem_cache_if_exists_otherwise_bypass_cache:" <<
read_settings.read_from_filesystem_cache_if_exists_otherwise_bypass_cache <<
std::endl;
Review Comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
