FelixYBW commented on PR #6907: URL: https://github.com/apache/incubator-gluten/pull/6907#issuecomment-2299368836
> @FelixYBW The reason is as follows: > > 1. When I change some c++ code, and submit the PR, the PR will fail at code style check. > 2. I noticed there is `dev/formatcppcode.sh`, but it only support Linux > 3. After make `dev/formatcppcode.sh` support macOS, I found that clang-format on macOS(which is of version 18) behaves differently from clang-format-15 on Linux. > 4. And there seems no easy way to install clang-format-15 on macOS. > > Do you have suggestions? Different OS has different default clang-format version. e.g. I'm using Ubuntu20.04 which has clang-format-12. Do 12 and 18 have any difference on format? format-12 works well on my side so far. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
