Yohahaha commented on issue #6970: URL: https://github.com/apache/incubator-gluten/issues/6970#issuecomment-2304373931
> > > > .backend. can be removed. > > > > > > > > > Yes that's one possible solution. If we drop `.backend`, then for the option keys that are common to all backends, say `spark.gluten.sql.columnar.broadcastJoin`, I think we could insert a `common.` or something to distinguish the namespace with backend configs, e.g., rename it to `spark.gluten.common.broadcastJoin`. > > > Basically we have two ideas: > > > > > > * Idea 1, `backend.` for backend configs > > > > > > * `spark.gluten.sql.columnar.backend.velox.ioThread` renamed to `spark.gluten.backend.velox.ioThread` > > > * `spark.gluten.sql.columnar.broadcastJoin` renamed to `spark.gluten.broadcastJoin` > > > * Idea 2, `common.` for common configs > > > > > > * `spark.gluten.sql.columnar.backend.velox.ioThread` renamed to `spark.gluten.velox.ioThread` > > > * `spark.gluten.sql.columnar.broadcastJoin` renamed to `spark.gluten.common.broadcastJoin` > > > > > > We could initial a vote on this. > > To me 2 looks better so far, since it categorizes the configs to fixed length of prefixes, which is 3, e.g., `s.g.common`, and `s.g.velox`. and it's closer to your suggestion either. I think we can put the direction on 2, once someone questioned, then we can decide whether to vote. I'm ok with `s.g.velox` and `s.g.common`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
