ArnavBalyan commented on PR #6905: URL: https://github.com/apache/incubator-gluten/pull/6905#issuecomment-2308776724
> I see we use synchronized collections and `synchronized` keywords at the same time. Were they for similar purpose? If yes, can we only keep one of them? So the code will be easier to understand and maintain. Say if synchronized collections are not enough for our case, we can just use `synchronized` + normal collections. > > In addition, if we decide to stay on `synchronized` keywords, I assume its usage in method `mapAndLoad` is not needed now. Since method `load` is already atomic (because `mapLibraryName` should be stateless?). Updated thanks, we need synchronized since there were thread unsafe operations being done outside the collections. I have removed the synchronized collection and kept the keyword, there were not much changes so the code flow is more simple now. Also removed it from mapAndLoad, since we have load protected anyway thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
