zhztheplayer commented on PR #7011: URL: https://github.com/apache/incubator-gluten/pull/7011#issuecomment-2312324344
Sorry, I am not aside a PC now, so I can't actually reason about the code, which looks too magical to me by the way. But what's clear is only input and output metrics were being handled separately when the code was [firstly written](https://github.com/Yohahaha/gluten/commit/7996326ddf6e1c8441d3184a8e39036d501ea2ee) . > TableWriter count physicalWrittenBytes, writeIONanos, numWrittenFiles, but only numWrittenFiles is merged After all, I think we should make these 4 metrics consistent. Either merge them all, or none of them. And seems to be safe to merge them all by taking one look. cc @JkSelf -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
