KevinyhZou commented on code in PR #7034:
URL: https://github.com/apache/incubator-gluten/pull/7034#discussion_r1734285642
##########
backends-clickhouse/src/test/scala/org/apache/gluten/execution/hive/GlutenClickHouseHiveTableSuite.scala:
##########
@@ -877,12 +877,15 @@ class GlutenClickHouseHiveTableSuite
val select_sql_5 = "select id, get_json_object(data, 'v112') from
test_tbl_3337"
val select_sql_6 =
"select id, get_json_object(data, '$.id') from test_tbl_3337 where id =
123"
+ val select_sql_7 =
+ "select id, get_json_object(data, '$.id') from test_tbl_3337"
compareResultsAgainstVanillaSpark(select_sql_1, compareResult = true, _ =>
{})
compareResultsAgainstVanillaSpark(select_sql_2, compareResult = true, _ =>
{})
compareResultsAgainstVanillaSpark(select_sql_3, compareResult = true, _ =>
{})
compareResultsAgainstVanillaSpark(select_sql_4, compareResult = true, _ =>
{})
compareResultsAgainstVanillaSpark(select_sql_5, compareResult = true, _ =>
{})
compareResultsAgainstVanillaSpark(select_sql_6, compareResult = true, _ =>
{})
+ compareResultsAgainstVanillaSpark(select_sql_7, compareResult = true, _ =>
{})
Review Comment:
maybe we should open the `get_json_object` test in spark-ut ，to ensure no
other corner case problems?
##########
cpp-ch/local-engine/Functions/SparkFunctionGetJsonObject.h:
##########
@@ -16,8 +16,8 @@
*/
#pragma once
#include <memory>
-#include <string_view>
#include <stack>
Review Comment:
remove `#include <stack>`, not used now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
