liuneng1994 commented on code in PR #6723:
URL: https://github.com/apache/incubator-gluten/pull/6723#discussion_r1743371895
##########
gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/OffloadSingleNode.scala:
##########
@@ -332,6 +332,8 @@ case class OffloadProject() extends OffloadSingleNode with
LogLevelUtil {
expr => rewriteExpr(expr,
replacedExprs).asInstanceOf[NamedExpression]
}
val newChild = addMetadataCol(projectExec.child, replacedExprs)
+ // tag child again, addMetadataCol lost the tag.
+ addHint.apply(newChild)
Review Comment:
@zhztheplayer please help review this code, fixed an issue where fallback
could not be performed correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
