marin-ma commented on code in PR #6869:
URL: https://github.com/apache/incubator-gluten/pull/6869#discussion_r1744693857
##########
cpp/velox/tests/VeloxShuffleWriterTest.cc:
##########
@@ -70,24 +70,28 @@ std::vector<ShuffleTestParams> createShuffleTestParams() {
std::vector<int32_t> mergeBufferSizes = {0, 3, 4, 10, 4096};
for (const auto& compression : compressions) {
- for (auto useRadixSort : {true, false}) {
- params.push_back(ShuffleTestParams{
- ShuffleWriterType::kSortShuffle, PartitionWriterType::kLocal,
compression, 0, 0, useRadixSort});
+ for (const auto compressionBufferSize : {4, 56, 32 * 1024}) {
Review Comment:
Yes. The condition of splitting a large row is the row size >
compressionBufferSize. When compressionBufferSize is 4, most of the rows will
be split.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
